Skip to content

Conversation

@Kurami32
Copy link
Collaborator

@Kurami32 Kurami32 commented Aug 29, 2025

Description
Hi! I replaced the default HTML5 player of the browser, with Plyr.

I used this package on the frontend, which is a wrapper of plyr but for Vue: vue-plyr

Here the changes:

  • Added a custom media player for both, audio and video.
  • Added a indicator (a toast) that shows when you active the "loop" mode on videos and audio by pressing the letter "L".
  • Updated en.json adding a new entry for the toast.
  • Added a custom-player.css for personalize the media player.
  • Updated styles.css for add the new CSS for the media player.
  • Updated Preview.vue, here I did most of the changes for both, the media player and the custom toast.
  • Updated main.ts with a entry that imports the package for the media player.
  • I also edited the "red" color on _variables.css with another tone.

Regarding to subtitles... they somehow work with a file. I don't tested with embedded subs.
And sorry if some lines were "moved" my editor auto-align the code automatically when saving.

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details

2025-08-29.15-07-44.mp4
  • Phone:
    Screenshot_20250829-151247_FileBrowser Quantum
    Screenshot_20250829-151354_FileBrowser Quantum
    Screenshot_20250829-151407_FileBrowser Quantum

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Aug 29, 2025

I linked my github account, I believe that now should pass all the tests.

Edit: Yep! Passed all.

@gtsteffaniak
Copy link
Owner

Nice this looks great! I actually had that video player starred to check it out sometime.T hanks for all the work. A few thoughts as you get the PR settled with tests and updates:

  1. why did the go backend imports change? seems like there should be no backend change required here.
  2. changing the red tone is total preference, was there a reason other than preference for the change that would impact everyone? Not against it, just curious.
  3. I have no issues with adding a new media player, but would like to make it optional. I can do that later after merging (maybe a use "browser default media player" in settings)

@gtsteffaniak gtsteffaniak changed the base branch from main to dev/v0.8.4 August 29, 2025 21:36
@Kurami32
Copy link
Collaborator Author

Kurami32 commented Aug 29, 2025

why did the go backend imports change? seems like there should be no backend change required here.

I only installed the package on the frontend, so I'm not sure... I don't modified anything manually there.

changing the red tone is total preference, was there a reason other than preference for the change that would impact everyone? Not against it, just curious.

Well... I like more pure red, than red pastel, but if you want, you can revert this later. And yes, was preference.

I have no issues with adding a new media player, but would like to make it optional. I can do that later after merging (maybe a use "browser default media player" in settings)

For me is fine if you make it optional, is better!

@gtsteffaniak
Copy link
Owner

ok I am updating and rebasing to 0.8.4 which also has the embedded subtitles support, i will make sure it works with this too.

@gtsteffaniak gtsteffaniak merged commit a933d7e into gtsteffaniak:dev/v0.8.4 Aug 29, 2025
14 checks passed
@gtsteffaniak gtsteffaniak mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants