-
Notifications
You must be signed in to change notification settings - Fork 251
Custom Media Player #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Media Player #1160
Conversation
Added a custom media player
Media player CSS
|
I linked my github account, I believe that now should pass all the tests. Edit: Yep! Passed all. |
|
Nice this looks great! I actually had that video player starred to check it out sometime.T hanks for all the work. A few thoughts as you get the PR settled with tests and updates:
|
I only installed the package on the frontend, so I'm not sure... I don't modified anything manually there.
Well... I like more pure red, than red pastel, but if you want, you can revert this later. And yes, was preference.
For me is fine if you make it optional, is better! |
|
ok I am updating and rebasing to 0.8.4 which also has the embedded subtitles support, i will make sure it works with this too. |
Description
Hi! I replaced the default HTML5 player of the browser, with Plyr.
I used this package on the frontend, which is a wrapper of plyr but for Vue: vue-plyr
Here the changes:
en.jsonadding a new entry for the toast.custom-player.cssfor personalize the media player.styles.cssfor add the new CSS for the media player.Preview.vue, here I did most of the changes for both, the media player and the custom toast.main.tswith a entry that imports the package for the media player._variables.csswith another tone.Regarding to subtitles... they somehow work with a file. I don't tested with embedded subs.
And sorry if some lines were "moved" my editor auto-align the code automatically when saving.
Additional Details
2025-08-29.15-07-44.mp4