Missing trailing slash when opening a source or creating a new folder

[d0gkiller87]

Description
Tested on v0.7.12-beta. When opening a source via the navbar or creating a new folder using the right-click menu, the resulting URL is missing a trailing slash. This causes issues when creating a file or folder, although the item has been successfully created, the resulting URL becomes malformed.

Some examples:

• Clicking source1 redirects to https://example.com/files/source1. Creating a folder named folder1 from this page redirects you to https://example.com/files/source1folder1 (broken)
• If you manually go to https://example.com/files/source1/ and create folder1, the redirect becomes https://example.com/files/source1/folder1 which will also be broken once you try to create a file/folder here

Expected Behavior
The resulting URL after opening a source or creating a new folder should include a trailing slash. Ideally, the website should automatically ensure a trailing slash is appended before redirecting to other paths to prevent malformed pages.

[gtsteffaniak]

can you check if this is an issue on 0.7.13?

[d0gkiller87]

I can confirm the trailing slash issue has been resolved in v0.7.13-beta, thanks.

However, this version introduced a new issue: sources with spaces (and possibly other special characters) in their names are no longer accessible.

For example, when accessing a source named my source, the URL becomes https://example.com/files/my%20source, followed by an error Error: {"status":403,"message":"source with name not found my%20source"}

Do we track this in a separate issue?

[gtsteffaniak]

Thanks for confirming. yeah unfotunately that appears to be a regression. Most of the time I prevent regressions like that with the integration tests, but I guess I don't have a test for that , which I can add.

Should be a simple fix, I did add a small change getting the source name initially, that is probably related to this.

I've opened this to track: #948

[d0gkiller87]

New issue discovered on v0.7.13-beta:

1. Visit https://example.com/files/source1
2. Click on dir1, the URL becomes https://example.com/files/source1/dir1
3. Use the search menu to search for a subdirectory (e.g. sub1) and enter it via the search result. The URL becomes https://example.com/files/source1/dir1sub1 instead of https://example.com/files/source1/dir1/sub1.

[gtsteffaniak]

Will fix tomorrow in a bugfix for this.

[gtsteffaniak]

Should be solved in 0.7.14

[d0gkiller87]

Can confirm all listed issues above are fixed in v0.7.14-beta. Thanks for the fix😊