FBQ 0.8.0 Beta Download limit not working

[maxlivi]

Description

The download limit doesn't work, after setting it to 1 the share is still accessible for further downloads.

Thanks

[christaikobo]

Can confirm that this is indeed happening.

[gtsteffaniak]

I found the issue and have a fix.

[christaikobo]

I just tested 0.8.1, still not fixed it seems.

[maxlivi]

It is working for me

Tried with a limit of 10 and and after I got :

 {
  "status": 403,
  "message": "share downloads limit reached"
}

Also I like the counter !

[christaikobo]

Weird, I'll test again later.

[christaikobo]

I did some more testing, it is related to #1090

If I share a PDF, I can repeatedly use the share link to infinitely download the PDF.

[gtsteffaniak]

yeah I think I know whats going on. If a filetype has a viewer, viewing doesn't count as a download. Only requests to the raw download link count towards a download.

So, for a PDF you can view it in the browser and probably even download it using the browser download option. If you want to enforce download count for a file like that, you would need to disable file viewing.

It's also a bit nuanced, because onlyoffice files use the download URL to access the file, so that would count towards a download... which I think I would need to make an exception for.

[christaikobo]

I'll wait for #1090 to be fixed and then do some more testing.

I think if a download limit can be easily circumvented, it kinda beats the purpose of a limit.

[gtsteffaniak]

actually, looks like thats not the case. The pdf viewer uses the inline download url to get the source , so it would count.

There was just a bug I found and fixed it! and youre right, I can make sure its enforced everywhere raw content is retrieved, counting it as a "download" even if it isn't technically downloaded.