fix: Handling Query Parameters in Request Processing #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In Resolver Version 3.0, when resolving a URL with query parameters, the implementation simply appends the incoming query parameters to the service URL saved in the database.
However, if the saved service URL already includes its own query parameters, the additional parameters are concatenated using
?
instead of&
.This results in an invalid URL structure, causing the redirect to fail.
Example
Request:
Registered service URL:
Actual redirect result (invalid):
Cause
In web_server/src/web_namespace.py, the code assumes that the service URL does not already contain any query parameters.
Relevant code:
Solution
I fixed the implementation so that if the service URL already contains a
?
, the additional query parameters will be concatenated using&
instead of?
.This prevents invalid URL structures and ensures a correct redirect.Updated code:
Let me know if you’d like me to clarify or adjust any part of this.