Skip to content

Upgrade protobuf and grpc deps #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampajano merged 3 commits into from
Mar 8, 2022
Merged

Upgrade protobuf and grpc deps #1211

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c3fc4
Upgrade protobuf and grpc deps
aapeliv Feb 26, 2022
d5508cc
Update protobuf version in prereqs dockerfile
aapeliv Mar 7, 2022
8405bb1
Merge branch 'master' into master
sampajano Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ http_archive(

http_archive(
name = "com_google_protobuf",
sha256 = "77ad26d3f65222fd96ccc18b055632b0bfedf295cb748b712a98ba1ac0b704b2",
strip_prefix = "protobuf-3.17.3",
sha256 = "ba0650be1b169d24908eeddbe6107f011d8df0da5b1a5a4449a913b10e578faf",
strip_prefix = "protobuf-3.19.4",
Comment thread
aapeliv marked this conversation as resolved.
urls = [
"https://github.com/protocolbuffers/protobuf/releases/download/v3.17.3/protobuf-all-3.17.3.tar.gz",
"https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protobuf-all-3.19.4.tar.gz",
],
)

http_archive(
name = "com_github_grpc_grpc",
sha256 = "43feda4d7ce2892400d5a0cbccecc5b1790f3253244a171360018d84c2949fb7",
strip_prefix = "grpc-1.33.2",
sha256 = "de2d3168e77e5ffb27758b07e87f6066fd0d8087fe272f278771e7780e6aaacb",
strip_prefix = "grpc-1.44.0",

@sampajano sampajano Mar 7, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if this update is also necessary? Could you provide the error if it's not updated if so (or maybe it's part of the same log you already mentioned)? thanks! :)

@aapeliv aapeliv Mar 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gRPC is giving the error and is the main issue. I bumped protobuf just because I saw it was a bit out of date

@sampajano sampajano Mar 7, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha i see! I was confused.. Thanks for explaining! :)

urls = [
"https://github.com/grpc/grpc/archive/v1.33.2.zip",
"https://github.com/grpc/grpc/archive/v1.44.0.zip",
],
)

Expand Down
2 changes: 1 addition & 1 deletion net/grpc/gateway/docker/prereqs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
FROM buildpack-deps:stretch AS prepare

ARG BUILDIFIER_VERSION=1.0.0
ARG PROTOBUF_VERSION=3.17.3
ARG PROTOBUF_VERSION=3.19.4

RUN apt-get -qq update && apt-get -qq install -y curl unzip

Expand Down