Fix issue where no RPC is issued when deadline is specified. - #1172
Merged
Conversation
sampajano
force-pushed
the
1-fix-deadline-crash
branch
2 times, most recently
from
November 19, 2021 02:37
19d0f39 to
fb0d2f1
Compare
sampajano
force-pushed
the
1-fix-deadline-crash
branch
3 times, most recently
from
November 19, 2021 08:48
d0b6e11 to
986426f
Compare
sampajano
force-pushed
the
1-fix-deadline-crash
branch
from
November 19, 2021 08:49
986426f to
548b0a4
Compare
sampajano
added
release notes: major
release notes: yes
and removed
release notes: yes
release notes: major
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
This is a temporary hack to fix #1153, which is caused by
goog.globalnot properly pointing to the proper global scope (e.g.window) when grpc-web is being imported as a CommonJS module (becausethispoints to the module scope instead of actual global scope (i.e.globalThis)).goog.Timer.defaultTimerObjectis set to point togoog.global, and that's why it throws whensetTimeoutis called on it.The fix
globalThiswhen possible, and if it's not available (pre-2020 browsers, etc.), fallback toself, which should work in both browsers and workers.