Add missing class exports - #1164
Conversation
|
|
sampajano
left a comment
sampajano
left a comment
There was a problem hiding this comment.
Thanks so much for the change! 😃 (I'll wait for another important bug fix and create a bug fix release soon 😃)
Also adding @stanley-cheung to take a look too 😃
| const RpcError = goog.require('grpc.web.RpcError'); | ||
| const StatusCode = goog.require('grpc.web.StatusCode'); | ||
| const MethodDescriptor = goog.require('grpc.web.MethodDescriptor'); | ||
| const MethodType = goog.require('grpc.web.MethodType'); |
There was a problem hiding this comment.
nit: do you mind help sort this line as well? :)
There was a problem hiding this comment.
The order reflects exports from index.d.ts? Is this ok?
There was a problem hiding this comment.
Ah thanks for the considerations :)
Personally i still prefer the exports to be alphabetically ordered in this file, given the connection to index.d.ts is an obscure one and would be harder to maintain (especially if we don't even document it here).
But i'm fine if you want to leave this as is in this PR :)
4 participants
Added exports for classes with constructors so that they can be used with Typescript.
Fixes #1158.