Allow clients to set a max age for connections #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some load balancers reject new streams when a client certificate has expired but allow existing ones to continue. This is problematic because there's no signal that the connection can't be used anymore so new RPCs will continue to fail. Modifications: Allow clients to configure a max age for connections, after which time the connection will shutdown gracefully. This allows new connections to be established. Result: Client connections can be configured to age out
Co-authored-by: Gus Cairo <[email protected]>
gjcairo
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some load balancers reject new streams when a client certificate has expired but allow existing ones to continue. This is problematic because there's no signal that the connection can't be used anymore so new RPCs will continue to fail.
Modifications:
Allow clients to configure a max age for connections, after which time the connection will shutdown gracefully. This allows new connections to be established.
Result:
Client connections can be configured to age out