Migrate speech to text example app to swift package manager & fix compile errors #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
May 10, 2022
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| import GRPC | |||
| import Logging | |||
| import Foundation | |||
There was a problem hiding this comment.
The formatter doesn't like the order of these imports, I don't think we need Foundation here so let's just remove it.
Suggested change
| import Foundation |
There was a problem hiding this comment.
When I remove the import, the compiler has trouble finding Data for the stream(_ data: Data, ..) method below. Not 100% certain why, my hunch would be that when removing Cocoapods a project setting changed that allowed it to not be required.
I've corrected the order of the imports 👍
glbrntt
reviewed
May 10, 2022
glbrntt
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
After reading that SwiftNIO was dropping support for CocoaPods I thought it'd be fun to revisit the example App and refresh it.
I also believe this PR resolves #1393
Modifications:
resource.prototo generation step (Must have been added recently)