Skip to content

Raise minimum supported Swift version to 5.4 #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2022

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented May 4, 2022

Motivation:

SwiftNIO raised its minimum supported Swift version to 5.4 in the 2.40.0
release. To be able to use the latest updates, we must do the same.

Modifications:

  • Bump swift-tools-version to 5.4 in the various package manifests
    (including QPS and FuzzTesting)
  • Add excludes for non-source files (READMEs and protos)
  • Use 'executableTarget' instead of 'target' for executables
  • Update the README to reflect supported versions
  • Remove 5.2 and 5.3 from CI
  • Remove LinuxMain.swift as test discovery is enabled by default

Result:

Minimum supported Swift version is 5.4

Motivation:

SwiftNIO raised its minimum supported Swift version to 5.4 in the 2.40.0
release. To be able to use the latest updates, we must do the same.

Modifications:

- Bump swift-tools-version to 5.4 in the various package manifests
  (including QPS and FuzzTesting)
- Add excludes for non-source files (READMEs and protos)
- Use 'executableTarget' instead of 'target' for executables
- Update the README to reflect supported versions
- Remove 5.2 and 5.3 from CI
- Remove LinuxMain.swift as test discovery is enabled by default

Result:

Minimum supported Swift version is 5.4
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label May 4, 2022
@glbrntt glbrntt requested a review from FranzBusch May 4, 2022 09:17
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

@glbrntt glbrntt merged commit edcd6b9 into grpc:main May 4, 2022
@glbrntt glbrntt deleted the gb-minimum-swift-version branch May 4, 2022 09:44
glbrntt added a commit to glbrntt/grpc-swift that referenced this pull request May 4, 2022
Motivation:

SwiftNIO raised its minimum supported Swift version to 5.4 in the 2.40.0
release. To be able to use the latest updates, we must do the same.

Modifications:

- Bump swift-tools-version to 5.4 in the various package manifests
  (including QPS and FuzzTesting)
- Add excludes for non-source files (READMEs and protos)
- Use 'executableTarget' instead of 'target' for executables
- Update the README to reflect supported versions
- Remove 5.2 and 5.3 from CI
- Remove LinuxMain.swift as test discovery is enabled by default

Result:

Minimum supported Swift version is 5.4

(cherry picked from commit edcd6b9)
glbrntt added a commit that referenced this pull request May 4, 2022
Motivation:

SwiftNIO raised its minimum supported Swift version to 5.4 in the 2.40.0
release. To be able to use the latest updates, we must do the same.

Modifications:

- Bump swift-tools-version to 5.4 in the various package manifests
  (including QPS and FuzzTesting)
- Add excludes for non-source files (READMEs and protos)
- Use 'executableTarget' instead of 'target' for executables
- Update the README to reflect supported versions
- Remove 5.2 and 5.3 from CI
- Remove LinuxMain.swift as test discovery is enabled by default

Result:

Minimum supported Swift version is 5.4

(cherry picked from commit edcd6b9)
bimawa pushed a commit to StreamLayer/grpc-swift that referenced this pull request Jun 17, 2022
Motivation:

SwiftNIO raised its minimum supported Swift version to 5.4 in the 2.40.0
release. To be able to use the latest updates, we must do the same.

Modifications:

- Bump swift-tools-version to 5.4 in the various package manifests
  (including QPS and FuzzTesting)
- Add excludes for non-source files (READMEs and protos)
- Use 'executableTarget' instead of 'target' for executables
- Update the README to reflect supported versions
- Remove 5.2 and 5.3 from CI
- Remove LinuxMain.swift as test discovery is enabled by default

Result:

Minimum supported Swift version is 5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants