Release stream callback, once the stream has finished #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Feb 15, 2022
| } | ||
|
|
||
| internal init(on eventLoop: EventLoop, _ responseCallback: @escaping (Response) -> Void) { | ||
| self.eventLoop = eventLoop | ||
| self.responseCallback = responseCallback | ||
| self.initialMetadataPromise = eventLoop.makeLazyPromise() | ||
| self.trailingMetadataPromise = eventLoop.makeLazyPromise() | ||
| self.statusPromise = eventLoop.makeLazyPromise() | ||
| self.statusPromise = eventLoop.makePromise() |
There was a problem hiding this comment.
Can we keep this as a lazy promise and just replace the callback in handle and handleError?
There was a problem hiding this comment.
much better! will change!
fabianfett
force-pushed
the
ff-release-stream-callback
branch
from
24aa4d2 to
4c0a2ea
Compare
fabianfett
force-pushed
the
ff-release-stream-callback
branch
from
4c0a2ea to
17a8ffe
Compare
fabianfett
force-pushed
the
ff-release-stream-callback
branch
from
17a8ffe to
64b642f
Compare
glbrntt
reviewed
Feb 16, 2022
Co-authored-by: George Barnett <[email protected]>
fabianfett
force-pushed
the
ff-release-stream-callback
branch
from
26fce60 to
ec7d950
Compare
glbrntt
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we don't release the stream callback once we a stream has ended. This makes it really easy for adopters to run into retain cycles, they don't expect.
Changes