Add Sendable conformance to various types #1334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Dec 20, 2021
Comment on lines
162
to
163
| Request: Sendable, | ||
| Response: Sendable |
There was a problem hiding this comment.
Why do we have an explicit Request and Response here? Cant we say
where Deserializer.Output == Sendable, Serializer.Input == SendableThere was a problem hiding this comment.
Good idea, we can do that.
fabianfett
reviewed
Dec 20, 2021
Motivation: Sendable conformance is used to indicate that a type is thread-safe. Sendable checks are limited in 5.5 but will tighten in future Swift versions. Modifications: - Add `Sendable` conformance to a number of the new types added just for async/await - Add a `GRPCSendable` typealias to allow `Sendable` to be applied when it is available. This is used on the relevant types which existed before async/await support was added. Result: Wider Sendable conformance.
Okay, we can wait for @Lukasa to have a look -- no rush with this one tbh. |
|
Sadly the compiler is tripping over an assertion too: https://bugs.swift.org/browse/SR-15628 |
|
Closing in favour of #1378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sendable conformance is used to indicate that a type is thread-safe.
Sendable checks are limited in 5.5 but will tighten in future Swift
versions.
Modifications:
Sendableconformance to a number of the new types added just forasync/await
GRPCSendabletypealias to allowSendableto be applied whenit is available. This is used on the relevant types which existed
before async/await support was added.
Result:
Wider Sendable conformance.