Use {request,response}{s,stream} consistently #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-async-naming-consistency
branch
3 times, most recently
from
24e68ea to
4bae2c5
Compare
Lukasa
approved these changes
Dec 3, 2021
Motivation: Some of the new async-await APIs are inconsistent in their use of 'requests' vs 'requestStream' and 'responses' vs 'responseStream'. We should name things consistently. Modifications: - Rename 'requests' to 'requestStream' in generated server code - Rename 'responses' to 'responseStream' in client calls Result: More consistent naming.
glbrntt
force-pushed
the
gb-async-naming-consistency
branch
from
4bae2c5 to
abb15a7
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some of the new async-await APIs are inconsistent in their use of
'requests' vs 'requestStream' and 'responses' vs 'responseStream'. We
should name things consistently.
Modifications:
Result:
More consistent naming.