Surface transient channel errors #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Oct 7, 2024
gjcairo
force-pushed
the
surface-errors
branch
from
24adeee to
45bc5dc
Compare
gjcairo
changed the title
glbrntt
requested changes
Oct 9, 2024
Sources/GRPCNIOTransportCore/Client/Connection/GRPCChannel.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCNIOTransportCore/Client/Connection/LoadBalancers/RoundRobinLoadBalancer.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCNIOTransportCore/Client/Connection/LoadBalancers/RoundRobinLoadBalancer.swift
Outdated
Show resolved
Hide resolved
| @@ -282,16 +282,27 @@ extension Subchannel { | |||
| } | |||
| } | |||
|
|
|||
| private func handleConnectFailedEvent(in group: inout DiscardingTaskGroup) { | |||
| private func handleConnectFailedEvent(in group: inout DiscardingTaskGroup, error: any Error) { | |||
There was a problem hiding this comment.
Rather than any Error, can we use RPCError and propagate it back to wherever the connectFailed event came from?
There was a problem hiding this comment.
Okay I had to do some gymnastics to get this done - not sure if it's compiler errors or I'm misunderstanding something about how Result deals with typed throws, but it wasn't too straightforward 😅
Sources/GRPCNIOTransportCore/Client/Connection/LoadBalancers/Subchannel.swift
Outdated
Show resolved
Hide resolved
glbrntt
requested changes
Oct 9, 2024
Sources/GRPCNIOTransportCore/Client/Connection/Connection.swift
Outdated
Show resolved
Hide resolved
| @@ -127,9 +127,19 @@ package final class Connection: Sendable { | |||
| /// This function returns when the connection has closed. You can observe connection events | |||
| /// by consuming the ``events`` sequence. | |||
| package func run() async { | |||
| let connectResult = await Result { | |||
| try await self.http2Connector.establishConnection(to: self.address) | |||
| func establishConnectionOrThrow() async throws(RPCError) -> HTTP2Connection { | |||
There was a problem hiding this comment.
These are the right gymnastics: the other way to do this is to be explicit with the types in the catching: closure:
await Result { () async throws(RPCError) -> HTTP2Connection in
// ...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR better surfaces transient errors happening deeper in the channel to provide more information to the user.
It depends on grpc/grpc-swift#2083 and grpc/grpc-swift#2084.