benchmarks: Avoid sending a message after half close #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't impact test behavior per-se, but causes it to produce less useless log output of the form: java.lang.IllegalStateException: call was half-closed at com.google.common.base.Preconditions.checkState(Preconditions.java:174) at io.grpc.internal.ClientCallImpl.sendMessage(ClientCallImpl.java:380) at io.grpc.stub.ClientCalls$CallToStreamObserverAdapter.onNext(ClientCalls.java:299) at io.grpc.benchmarks.driver.LoadClient$AsyncPingPongWorker$1.onNext(LoadClient.java:406) at io.grpc.benchmarks.driver.LoadClient$AsyncPingPongWorker$1.onNext(LoadClient.java:400) at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onMessage(ClientCalls.java:382) at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1MessageRead.runInContext(ClientCallImpl.java:473) ... 7 more Fixes grpc#2372
ejona86
force-pushed
the
de-error-loadclient
branch
from
1658b81 to
f3ab4a4
Compare
|
@carl-mastrangelo, I pushed a cleaner version. |
| @@ -403,11 +403,13 @@ public void run() { | |||
| @Override | |||
| public void onNext(Messages.SimpleResponse value) { | |||
| delay(System.nanoTime() - now); | |||
There was a problem hiding this comment.
nit: won't now be wrong here?
There was a problem hiding this comment.
onNext won't be called again. If it is, then an exception will be thrown because onCompleted is called more than once.
There was a problem hiding this comment.
oh, I meant on the first time through
There was a problem hiding this comment.
now is initialized to nanoTime(), and the first message is sent outside of the StreamObserver. So it looks like it is consistent.
carl-mastrangelo
approved these changes
Oct 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't impact test behavior per-se, but causes it to produce less
useless log output of the form:
Fixes #2372