extproc: implement ClientFilter and ClientFilterBuilder interface#9086
Open
eshitachandwani wants to merge 10 commits intogrpc:masterfrom
Open
extproc: implement ClientFilter and ClientFilterBuilder interface#9086eshitachandwani wants to merge 10 commits intogrpc:masterfrom
eshitachandwani wants to merge 10 commits intogrpc:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9086 +/- ##
==========================================
+ Coverage 80.52% 83.07% +2.54%
==========================================
Files 413 415 +2
Lines 33543 33527 -16
==========================================
+ Hits 27012 27854 +842
+ Misses 4316 4243 -73
+ Partials 2215 1430 -785
🚀 New features to boost your workflow:
|
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Envoy external processing filter, providing configuration parsing logic and the infrastructure to build a client interceptor. Feedback addresses a critical uninitialized function variable that would cause a panic during filter construction and suggests a performance optimization for slice allocation when converting string matchers.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of implementing A93: xds-ext-proc
This PR adds the builder that implements the ClientFilter and ClientFilterBuilder interface. That includes creating the interceptor config from the base and the override config. It also includes making the ext_proc channel.
THis PR has a placeholder function for converting grpcService to ServerConfig proto. The function will be implemented later when implementing gRFC A102.
The
interceptorstruct has aresolver.ClientInterceptorembedded for now, but that will be removed in a later PR when we implement theresolver.ClientInterceptorinterface. Since the filter will not be registered and no one is calling theresolver.ClientInterceptorfunction fro extproc filter , it will not panic.#ext-proc-a93
RELEASE NOTES: None