Skip to content

balancer/rls: fix goroutine leak in control_channel_test #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eshitachandwani merged 3 commits into from
Feb 24, 2026
Merged

balancer/rls: fix goroutine leak in control_channel_test #8898

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51703c9
balancer/rls: fix goroutine leak in control_channel_test
maishivamhoo123 Feb 11, 2026
b25dc51
Merge branch 'master' into fix-rls-goroutine-leak
maishivamhoo123 Feb 11, 2026
ae02009
Merge branch 'master' of https://github.com/grpc/grpc-go into fix-rls…
maishivamhoo123 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions balancer/rls/control_channel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func (s) TestLookupDeadlineExceeded(t *testing.T) {
defer ctrlCh.close()

// Perform the lookup and expect the callback to be invoked with an error.
errCh := make(chan error)
errCh := make(chan error, 1)
ctrlCh.lookup(nil, rlspb.RouteLookupRequest_REASON_MISS, staleHeaderData, func(_ []string, _ string, err error) {
if st, ok := status.FromError(err); !ok || st.Code() != codes.DeadlineExceeded {
errCh <- fmt.Errorf("rlsClient.lookup() returned error: %v, want %v", err, codes.DeadlineExceeded)
Expand Down Expand Up @@ -367,7 +367,7 @@ func testControlChannelCredsFailure(t *testing.T, sopts []grpc.ServerOption, bop
defer ctrlCh.close()

// Perform the lookup and expect the callback to be invoked with an error.
errCh := make(chan error)
errCh := make(chan error, 1)
ctrlCh.lookup(nil, rlspb.RouteLookupRequest_REASON_MISS, staleHeaderData, func(_ []string, _ string, err error) {
if st, ok := status.FromError(err); !ok || st.Code() != wantCode || !wantErrRegex.MatchString(st.String()) {
errCh <- fmt.Errorf("rlsClient.lookup() returned error: %v, wantCode: %v, wantErr: %s", err, wantCode, wantErrRegex.String())
Expand Down
Loading