Skip to content

xds/resolver: change tests to update all resources - #8539

Merged
eshitachandwani merged 4 commits into
grpc:masterfrom
eshitachandwani:nre2etest
Aug 29, 2025
Merged

xds/resolver: change tests to update all resources#8539
eshitachandwani merged 4 commits into
grpc:masterfrom
eshitachandwani:nre2etest

Conversation

@eshitachandwani

Copy link
Copy Markdown
Member

Change the tests in xds resolver to update all resources in management server instead of only listener and route resource.

This change is being done as part of gRFC A74 : xDS Config tears. This is to make sure the tests pass after the change too.

RELEASE NOTES: None

@eshitachandwani eshitachandwani added this to the 1.76 Release milestone Aug 25, 2025
@eshitachandwani eshitachandwani added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Aug 25, 2025
@codecov

codecov Bot commented Aug 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (b0bc6dc) to head (4c970ff).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8539      +/-   ##
==========================================
- Coverage   82.09%   82.00%   -0.10%     
==========================================
  Files         412      412              
  Lines       40453    40465      +12     
==========================================
- Hits        33211    33184      -27     
- Misses       5869     5904      +35     
- Partials     1373     1377       +4     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/xds/resolver/helpers_test.go Outdated
Comment thread internal/xds/resolver/watch_service_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
@easwars easwars assigned eshitachandwani and unassigned easwars and arjan-bal Aug 25, 2025
Comment thread internal/xds/resolver/helpers_test.go Outdated
Routes: routes,
Clusters: clusters,
Endpoints: endpoints,
SkipValidation: true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to skip validation here? We do that in configureResourcesOnManagementServer because we don't specify all resources there.

@easwars easwars assigned eshitachandwani and unassigned easwars and arjan-bal Aug 28, 2025
@eshitachandwani
eshitachandwani merged commit fa246ef into grpc:master Aug 29, 2025
15 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants