xds/resolver: change tests to update all resources - #8539
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8539 +/- ##
==========================================
- Coverage 82.09% 82.00% -0.10%
==========================================
Files 412 412
Lines 40453 40465 +12
==========================================
- Hits 33211 33184 -27
- Misses 5869 5904 +35
- Partials 1373 1377 +4 🚀 New features to boost your workflow:
|
easwars
reviewed
Aug 25, 2025
easwars
approved these changes
Aug 28, 2025
| Routes: routes, | ||
| Clusters: clusters, | ||
| Endpoints: endpoints, | ||
| SkipValidation: true, |
Contributor
There was a problem hiding this comment.
Do we need to skip validation here? We do that in configureResourcesOnManagementServer because we don't specify all resources there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the tests in xds resolver to update all resources in management server instead of only listener and route resource.
This change is being done as part of gRFC A74 : xDS Config tears. This is to make sure the tests pass after the change too.
RELEASE NOTES: None