googlec2p: use xdstp style template for client LDS resource name#7048
Merged
arvindbr8 merged 2 commits intogrpc:masterfrom Mar 19, 2024
Merged
googlec2p: use xdstp style template for client LDS resource name#7048arvindbr8 merged 2 commits intogrpc:masterfrom
arvindbr8 merged 2 commits intogrpc:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7048 +/- ##
==========================================
+ Coverage 82.45% 82.49% +0.03%
==========================================
Files 299 300 +1
Lines 31314 31351 +37
==========================================
+ Hits 25819 25862 +43
+ Misses 4435 4431 -4
+ Partials 1060 1058 -2
|
apolcyn
reviewed
Mar 19, 2024
apolcyn
approved these changes
Mar 19, 2024
apolcyn
approved these changes
Mar 19, 2024
apolcyn
approved these changes
Mar 19, 2024
dfawley
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The google c2p resolver should be using the new xdstp style names for LDS resource names. Also adds "xds.config.resource-in-sotw" to
server_featureswhich is also required by the google c2p resolver.RELEASE NOTES: none