Skip to content

Upgrade version to 2.52.0-pre1 (on v2.52.x branch) #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

jtattermusch
Copy link
Contributor

No description provided.

@jtattermusch
Copy link
Contributor Author

Test failures:

Failed Active_UnaryCall_HostOverride_Success [20 s]
  Error Message:
   System.IO.IOException : Failed to bind to address [https://127.0.0.1:50052:](https://127.0.0.1:50052/) address already in use.
  ----> Microsoft.AspNetCore.Connections.AddressInUseException : Address already in use
  ----> System.Net.Sockets.SocketException : Address already in use
  Stack Trace:
     at Grpc.AspNetCore.FunctionalTests.Infrastructure.InProcessTestServer`1.StartServer() in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Infrastructure/InProcessTestServer.cs:line 114
   at Grpc.AspNetCore.FunctionalTests.Infrastructure.GrpcTestFixture`1..ctor(Action`1 initialConfigureServices, Action`2 configureKestrel, Nullable`1 defaultClientEndpointName) in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Infrastructure/GrpcTestFixture.cs:line 123
   at Grpc.AspNetCore.FunctionalTests.Balancer.BalancerHelpers.CreateServer(Int32 port, Nullable`1 protocols, Nullable`1 isHttps, X509Certificate2 certificate) in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Balancer/BalancerHelpers.cs:line 95
   at Grpc.AspNetCore.FunctionalTests.Balancer.BalancerHelpers.CreateGrpcEndpoint[TRequest,TResponse](Int32 port, UnaryServerMethod`2 callHandler, String methodName, Nullable`1 protocols, Nullable`1 isHttps, X509Certificate2 certificate) in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Balancer/BalancerHelpers.cs:line 60
   at Grpc.AspNetCore.FunctionalTests.Balancer.ConnectionTests.Active_UnaryCall_HostOverride_Success() in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Balancer/ConnectionTests.cs:line 314
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.GetResult()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--AddressInUseException
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass30_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
--SocketException
   at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
   at System.Net.Sockets.Socket.Bind(EndPoint localEP)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
  Standard Output Messages:
 0.001s GrpcTestContext - Information: Starting ConnectionTests.Active_UnaryCall_HostOverride_Success
 20.094s GrpcTestContext - Information: Finishing ConnectionTests.Active_UnaryCall_HostOverride_Success


  Failed Active_UnaryCall_MultipleStreams_UnavailableAddress_FallbackToWorkingAddress [20 s]
  Error Message:
   System.IO.IOException : Failed to bind to address [https://127.0.0.1:50052:](https://127.0.0.1:50052/) address already in use.
  ----> Microsoft.AspNetCore.Connections.AddressInUseException : Address already in use
  ----> System.Net.Sockets.SocketException : Address already in use
  Stack Trace:
     at Grpc.AspNetCore.FunctionalTests.Infrastructure.InProcessTestServer`1.StartServer() in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Infrastructure/InProcessTestServer.cs:line 114
   at Grpc.AspNetCore.FunctionalTests.Infrastructure.GrpcTestFixture`1..ctor(Action`1 initialConfigureServices, Action`2 configureKestrel, Nullable`1 defaultClientEndpointName) in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Infrastructure/GrpcTestFixture.cs:line 123
   at Grpc.AspNetCore.FunctionalTests.Balancer.BalancerHelpers.CreateServer(Int32 port, Nullable`1 protocols, Nullable`1 isHttps, X509Certificate2 certificate) in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Balancer/BalancerHelpers.cs:line 95
   at Grpc.AspNetCore.FunctionalTests.Balancer.BalancerHelpers.CreateGrpcEndpoint[TRequest,TResponse](Int32 port, UnaryServerMethod`2 callHandler, String methodName, Nullable`1 protocols, Nullable`1 isHttps, X509Certificate2 certificate) in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Balancer/BalancerHelpers.cs:line 60
   at Grpc.AspNetCore.FunctionalTests.Balancer.ConnectionTests.Active_UnaryCall_MultipleStreams_UnavailableAddress_FallbackToWorkingAddress() in /home/runner/work/grpc-dotnet/grpc-dotnet/test/FunctionalTests/Balancer/ConnectionTests.cs:line 168
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.GetResult()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--AddressInUseException
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass30_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
--SocketException
   at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
   at System.Net.Sockets.Socket.Bind(EndPoint localEP)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
  Standard Output Messages:
 0.001s GrpcTestContext - Information: Starting ConnectionTests.Active_UnaryCall_MultipleStreams_UnavailableAddress_FallbackToWorkingAddress
 20.086s GrpcTestContext - Information: Finishing ConnectionTests.Active_UnaryCall_MultipleStreams_UnavailableAddress_FallbackToWorkingAddress

@jtattermusch
Copy link
Contributor Author

The test run was a flake, so I'll proceed, but it should still get looked at (looks like multiple tests try to bind the same port, which is inherently flawed).

@jtattermusch jtattermusch merged commit 347dfea into v2.52.x Mar 3, 2023
@jtattermusch
Copy link
Contributor Author

The release was published: https://github.com/grpc/grpc-dotnet/releases/tag/v2.52.0-pre1
(and nugets uploaded)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants