Open
Conversation
Owner
|
idk if the other executable are tested, but if they are can you add a test for asdf too ? |
Owner
|
looks about right |
Author
|
It took me a while to setup a Docker image that included rvm and the different ruby version. (Vagrant was not an option for me). The tests just finished running on my machine. I get 2 failures:
|
Owner
|
I was hoping most of the tests would just work if there are different ruby versions installed locally :( |
Author
|
🤦♂️ oh you're right! I didn't think of that. I'll install the different versions and run the test suite locally and report back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for this gem.
Adding another lovely version manager to the mix: asdf
Unfortunately I was not able to run the test suite on my machine. Making a PR and delegating that job to Travis 🤞