Skip to content

Adds check for asdf presence#53

Open
idabmat wants to merge 1 commit intogrosser:masterfrom
idabmat:master
Open

Adds check for asdf presence#53
idabmat wants to merge 1 commit intogrosser:masterfrom
idabmat:master

Conversation

@idabmat
Copy link
Copy Markdown

@idabmat idabmat commented Jul 10, 2018

Hi! Thank you for this gem.

Adding another lovely version manager to the mix: asdf

Unfortunately I was not able to run the test suite on my machine. Making a PR and delegating that job to Travis 🤞

@grosser
Copy link
Copy Markdown
Owner

grosser commented Jul 10, 2018

idk if the other executable are tested, but if they are can you add a test for asdf too ?

@grosser
Copy link
Copy Markdown
Owner

grosser commented Jul 10, 2018

looks about right
... what error do you see when running tests ?

@idabmat
Copy link
Copy Markdown
Author

idabmat commented Jul 10, 2018

It took me a while to setup a Docker image that included rvm and the different ruby version. (Vagrant was not an option for me).

The tests just finished running on my machine. I get 2 failures:

  • jruby-9.2 was not installed
  • WWTD CLI --parallel runs in parallel because my machine took too long to run the test

@grosser
Copy link
Copy Markdown
Owner

grosser commented Jul 10, 2018

I was hoping most of the tests would just work if there are different ruby versions installed locally :(

@idabmat
Copy link
Copy Markdown
Author

idabmat commented Jul 10, 2018

🤦‍♂️ oh you're right! I didn't think of that. I'll install the different versions and run the test suite locally and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants