Skip to content

Bugs with new fitToContent (1rem, calling cellHeight) #2427

@ExusAltimus

Description

@ExusAltimus

Subject of the issue

Issue 1: fitToContent / misbehaving not working when cellHeight is not an integer (1rem support) FIXED

Issue 2: Starting with column 2, then changing the cellHeight, then changing the column to 1 will revert it back to 2 column

Issue 3: Changing cellHeight will not auto size the cell to content height
NOTE: This may not be a bug and may be intended behavior, i.e call resizeToContent on cellHeight() call
FIXED

Issue 4: Clicking add widget will not auto size the cell to the content height (added makeWidget version too because this is my typical flow)
NOTE: This may not be a bug and may be intended behavior, i.e call resizeToContent on widget add (addWidget or makeWidget)
FIXED

Your environment

Gridstack Version 9.0.1 (using gridstack.extra.css)
Google Chrome, Edge

Steps to reproduce

https://jsfiddle.net/zxwg5j7m/101/
Issue 1 + 3
36b59a30de7c6c75bfe704f54d8347a9

Issue 2
4000c84651a8817f6bbd5c04b1ea4c41

Issue 4
Image from Gyazo

Expected behavior

Cell should fit to content,
addWidget / makeWidget should auto size the cell
cellHeight should auto size the cell

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions