Skip to content

[flags] Cleanup enableHalt#476

Closed
everettbu wants to merge 4 commits into
mainfrom
sebbie/02-05-_flags_cleanup_enablehalt_
Closed

[flags] Cleanup enableHalt#476
everettbu wants to merge 4 commits into
mainfrom
sebbie/02-05-_flags_cleanup_enablehalt_

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35708
Original author: eps1lon


This has shipped in 19.2

@everettbu everettbu added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 5, 2026
@everettbu everettbu marked this pull request as ready for review February 5, 2026 19:25
@greptile-apps

greptile-apps Bot commented Feb 5, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

  • Removes the enableHalt feature flag and all associated conditionals in React Fizz/Flight server implementations so halt semantics are unconditional for prerender abort paths.
  • Simplifies static prerender APIs (Browser/Edge/Node) to always return StaticResult with a postponed field.
  • Updates and ungates a large set of DOM/Flight prerender tests to reflect the now-always-on halt behavior, including pruning the previous “halt disabled” expectations.
  • Adjusts a few stack-location inline snapshots in Flight DOM browser/node tests after line shifts.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are a straightforward removal of a now-always-on feature flag plus corresponding test expectation updates; the head commit also confirms there are no remaining enableHalt references under packages, and the diff introduces no whitespace issues.
  • No files require special attention

Important Files Changed

Filename Overview
packages/react-dom/src/tests/ReactDOMFizzStaticBrowser-test.js Removes enableHalt conditional branches and disable-mode tests; updates gates on SuspenseList/OptimisticKey tests accordingly.
packages/react-dom/src/tests/ReactDOMFizzStaticNode-test.js Drops enableHalt gating and removes disable-mode tests/branches; assumes prerender abort returns empty prelude with errors.
packages/react-dom/src/server/ReactDOMFizzStaticBrowser.js Removes enableHalt flag usage; always includes postponed in StaticResult from prerender.
packages/react-server-dom-webpack/src/tests/ReactFlightDOMBrowser-test.js Removes enableHalt gating for prerender tests and adjusts stack-location inline snapshot numbers after earlier edits.
packages/react-server-dom-webpack/src/tests/ReactFlightDOMNode-test.js Removes enableHalt gating comments and updates stack-location inline snapshots to new line numbers.
packages/react-server/src/ReactFizzServer.js Eliminates enableHalt conditionals; prerender abort paths now always use tracked-postpones/segment checks to halt tasks.
packages/react-server/src/ReactFlightServer.js Eliminates enableHalt flag checks; PRERENDER abort behavior always halts tasks for thenables/streams/blobs and abort().
packages/shared/ReactFeatureFlags.js Removes the enableHalt feature flag export.
packages/shared/forks/ReactFeatureFlags.native-fb.js Removes enableHalt export from native-fb feature flags fork.
packages/shared/forks/ReactFeatureFlags.test-renderer.js Removes enableHalt export from test-renderer feature flags fork.
packages/shared/forks/ReactFeatureFlags.www.js Removes enableHalt export from www feature flags fork.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Feb 6, 2026
@everettbu everettbu deleted the sebbie/02-05-_flags_cleanup_enablehalt_ branch February 6, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants