[test] Exclude repository root from assertions#245
Closed
everettbu wants to merge 1 commit into
Closed
Conversation
Greptile OverviewGreptile SummaryThis PR fixes a test brittleness issue where path assertions would break when React is tested from different filesystem locations. The changes centralize repo root path handling by introducing a global Key changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35361
Original author: eps1lon
The repository root was hidden in string length assertions. Those broke once you tested React deeper in your filesystem.
Added the repo root behind a global
__REACT_ROOT_PATH_TEST__since that's used in a couple of places. Defining that for each test makes it annoying to move test file around.