support gren run --package
#294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinheghan
reviewed
Jun 21, 2025
| { package = package | ||
| } | ||
| ) | ||
| -- TODO: --package name (without equals) does not work. Is that expected? |
Member
There was a problem hiding this comment.
It's a known bug I've been meaning to fix in compiler-node since forever.
| makeProject config projectOutline = | ||
| when getOutputPath projectOutline is | ||
| Nothing -> | ||
| Task.fail NotAnApplication |
Member
There was a problem hiding this comment.
Do we want this restriction? 🤔
Makes it more hassle to test the programs "shipped" with gren run --package
Contributor
Author
There was a problem hiding this comment.
Unless I'm missing something this would only happen if platform=common, which means you can't have browser or node packages which means you can't run any modules in your package.
robinheghan
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TODOs we can discuss here but it's working.