Skip to content

Move CardGroup into shared components dir#1492

Merged
martha merged 1 commit into
mainfrom
mke/9245-make-card-group-shared
Jun 11, 2026
Merged

Move CardGroup into shared components dir#1492
martha merged 1 commit into
mainfrom
mke/9245-make-card-group-shared

Conversation

@martha

@martha martha commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Summary of changes:

  • Move the generic CardGroup component, currently only used in the Admin Form UI, to the common components directory so it can be used in other places, such as the Admin CE Match Rule UI.
  • Add aria text on the X button to delete a RemovableCard, resolving an axe warning

Depends on hmis-warehouse PR: n/a

How to test: No functional changes. Confirm that usages of removable cards still work correctly, such as: new Form Rule dialog; form item editor widgets such as EnableWhen, Autofill, etc.

Type of change

Code clean-up

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • I have used Axe DevTools to scan for accessibility issues (or not applicable)
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@martha martha requested a review from gigxz June 11, 2026 15:59
@martha martha merged commit fa74668 into main Jun 11, 2026
1 check passed
@martha martha deleted the mke/9245-make-card-group-shared branch June 11, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants