Skip to content

Simplify Assessment deletion permission checks#1471

Merged
martha merged 4 commits into
mainfrom
mke/9169-assmt-access
May 26, 2026
Merged

Simplify Assessment deletion permission checks#1471
martha merged 4 commits into
mainfrom
mke/9169-assmt-access

Conversation

@martha

@martha martha commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Summary of changes:

  • Replace the frontend logic for determining whether to show the Delete Assessment button, with one permission check that relies on the backend policy.
  • Note that this is a logical change from before!
    • Previously: The backend required only can_delete_enrollments to delete a completed Intake, but the frontend required can_delete_enrollments AND can_delete_assessments.
    • After this PR: Frontend is aligned with backend on the less strict version. You only need can_delete_enrollments to delete a completed Intake.

Depends on hmis-warehouse PR: greenriver/hmis-warehouse#6505

How to test: See QA instructions on ticket

Type of change

Code clean-up

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • I have used Axe DevTools to scan for accessibility issues (or not applicable)
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@martha martha marked this pull request as ready for review May 21, 2026 15:20
@martha martha requested a review from gigxz May 21, 2026 15:20
Base automatically changed from main to staging May 21, 2026 19:28
@martha martha changed the base branch from staging to main May 21, 2026 19:43

@gigxz gigxz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew good cleanup, thanks!

@martha martha merged commit bc0431a into main May 26, 2026
1 check passed
@martha martha deleted the mke/9169-assmt-access branch May 26, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants