Skip to content

technical upgrade on Docker system#39

Merged
dedece35 merged 5 commits intomainfrom
technical_upgrade
Jan 17, 2025
Merged

technical upgrade on Docker system#39
dedece35 merged 5 commits intomainfrom
technical_upgrade

Conversation

@dedece35
Copy link
Member

@dedece35 dedece35 commented Jan 8, 2025

local tests are OK with these modifications and with test-project with the PR green-code-initiative/creedengo-mobile-ios-swift-test-project#18

@dedece35 dedece35 self-assigned this Jan 8, 2025
@dedece35 dedece35 marked this pull request as draft January 8, 2025 22:06
@dedece35 dedece35 marked this pull request as ready for review January 8, 2025 22:30
@dedece35 dedece35 changed the title technical upgrades technical upgrade on Docker system Jan 8, 2025
@dedece35 dedece35 added the 🏗️ refactoring refactoring for best practices label Jan 8, 2025
container_name: sonar_creedengo_ios
ports:
- "9000:9000"
- ":9000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamic ports does not seem to work on macOS : I see not port binding when inspecting with Docker desktop

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comments on Slack

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

@dedece35 dedece35 merged commit 33ea66a into main Jan 17, 2025
3 checks passed
@dedece35 dedece35 deleted the technical_upgrade branch January 17, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏗️ refactoring refactoring for best practices

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants