Merged
Conversation
AMorgaut
force-pushed
the
95-provide-a-first-page-template
branch
from
952f62b to
e26d6b9
Compare
AMorgaut
requested changes
Aug 15, 2025
AMorgaut
previously requested changes
Aug 21, 2025
Collaborator
AMorgaut
left a comment
AMorgaut
left a comment
There was a problem hiding this comment.
praise: almost done! Thank you
See bellow Few proposals to make it even better
shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js
Outdated
Show resolved
Hide resolved
shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js
Outdated
Show resolved
Hide resolved
shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js
Outdated
Show resolved
Hide resolved
AMorgaut
force-pushed
the
95-provide-a-first-page-template
branch
from
e516c79 to
e5a05f7
Compare
AMorgaut
force-pushed
the
95-provide-a-first-page-template
branch
from
e5a05f7 to
5367cc7
Compare
|
AMorgaut
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.