Skip to content

feat: enable head component and native typegen #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

wardpeet
Copy link
Contributor

Description

Upgrading Gatsby to latest V4:

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 13, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wardpeet / name: Ward Peeters (5a42fd5)

@@ -1,4 +1,5 @@
{
"arrowParens": "avoid",
"semi": false
}
"semi": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow when I ran yarn format I got so many changes and this reduced it a little.

@Urigo
Copy link
Contributor

Urigo commented Nov 13, 2022

@orta @hwillson i tried to approve the preview in Netlify but couldn't figure out exactly how, do you know what is the latest flow?

@Urigo
Copy link
Contributor

Urigo commented Nov 13, 2022

I get these options but not sure what they are :)
image

@hwillson
Copy link
Member

@Urigo I don't have access to graphql.org's Netlify account, but I'm guessing things aren't configured to automatically allow builds from all PR contributors. The further action options are asking how to proceed since they can't validate the PR creator; e.g. selecting the Approve and add as Git Contributor option will add @wardpeet to the graphql.org Netlify team (details here). This shouldn't be needed though - there are ways to open this up so all PR's auto-build. Do you know who has admin level access for the graphql.org Netlify account? I can help adjust things if we can get access - while we're at it we could also look into getting doc preview builds automatically run as PR checks, with the links auto-added to each PR.

@Urigo
Copy link
Contributor

Urigo commented Nov 14, 2022

cc @leebyron can you help us change the setting here?

@Urigo
Copy link
Contributor

Urigo commented Nov 14, 2022

ok I got permissions!
Deployed it and everything looks fine for me
Merging

@Urigo Urigo merged commit 703844f into graphql:source Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants