Skip to content

collectFields: use ES6 collections instead of Object.create(null) #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

collectFields: use ES6 collections instead of Object.create(null) #3082

merged 1 commit into from
May 12, 2021

Conversation

IvanGoncharov
Copy link
Member

Also resulted in ~10% perfomance increase for execute at least on my machine:
image

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label May 12, 2021
@IvanGoncharov IvanGoncharov merged commit 0ebcb2f into graphql:main May 12, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch May 12, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IvanGoncharov