Skip to content

TS: use proper type for async generator #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021
Merged

TS: use proper type for async generator #3009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bfb313
feat: return AsyncGenerator
saihaj Mar 24, 2021
79554f7
build: sync integration test tsconfig with main tsconfig
saihaj Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrationTests/ts/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"module": "commonjs",
"lib": ["es6", "esnext.asynciterable"],
"lib": ["es2019", "es2020.string"],
"strict": true,
"noEmit": true,
"types": []
Expand Down
4 changes: 2 additions & 2 deletions src/subscription/mapAsyncIterator.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { PromiseOrValue } from '../jsutils/PromiseOrValue';
* which produces values mapped via calling the callback function.
*/
export function mapAsyncIterator<T, U>(
iterable: AsyncIterable<T>,
iterable: AsyncIterable<T> | AsyncGenerator<T, void, void>,
callback: (arg: T) => PromiseOrValue<U>,
rejectCallback?: (arg: any) => PromiseOrValue<U>,
): any; // TS_SPECIFIC: AsyncGenerator requires [email protected]
): AsyncGenerator<U, void, void>;
2 changes: 1 addition & 1 deletion src/subscription/subscribe.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface SubscriptionArgs {
*/
export function subscribe(
args: SubscriptionArgs,
): Promise<AsyncIterableIterator<ExecutionResult> | ExecutionResult>;
): Promise<AsyncGenerator<ExecutionResult, void, void> | ExecutionResult>;

/**
* Implements the "CreateSourceEventStream" algorithm described in the
Expand Down