Skip to content

validateSchema: inline 'getAllNodes' function #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2021
Merged

validateSchema: inline 'getAllNodes' function #2937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 12 additions & 25 deletions src/type/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,10 @@ function getOperationTypeNode(
schema: GraphQLSchema,
operation: OperationTypeNode,
): ?ASTNode {
const operationNodes = getAllSubNodes(schema, (node) => node.operationTypes);
for (const node of operationNodes) {
if (node.operation === operation) {
return node.type;
}
}
return undefined;
// istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
return getAllNodes(schema)
.flatMap((schemaNode) => schemaNode.operationTypes ?? [])
.find((operationNode) => operationNode.operation === operation)?.type;
}

function validateDirectives(context: SchemaValidationContext): void {
Expand Down Expand Up @@ -626,34 +623,24 @@ function getAllNodes<T: ASTNode, K: ASTNode>(
: extensionASTNodes ?? [];
}

function getAllSubNodes<T: ASTNode, K: ASTNode, L: ASTNode>(
object: SDLDefinedObject<T, K>,
getter: (T | K) => ?(L | $ReadOnlyArray<L>),
): $ReadOnlyArray<L> {
let subNodes = [];
for (const node of getAllNodes(object)) {
// istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
subNodes = subNodes.concat(getter(node) ?? []);
}
return subNodes;
}

function getAllImplementsInterfaceNodes(
type: GraphQLObjectType | GraphQLInterfaceType,
iface: GraphQLInterfaceType,
): $ReadOnlyArray<NamedTypeNode> {
return getAllSubNodes(type, (typeNode) => typeNode.interfaces).filter(
(ifaceNode) => ifaceNode.name.value === iface.name,
);
// istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
return getAllNodes(type)
.flatMap((typeNode) => typeNode.interfaces ?? [])
.filter((ifaceNode) => ifaceNode.name.value === iface.name);
}

function getUnionMemberTypeNodes(
union: GraphQLUnionType,
typeName: string,
): ?$ReadOnlyArray<NamedTypeNode> {
return getAllSubNodes(union, (unionNode) => unionNode.types).filter(
(typeNode) => typeNode.name.value === typeName,
);
// istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
return getAllNodes(union)
.flatMap((unionNode) => unionNode.types ?? [])
.filter((typeNode) => typeNode.name.value === typeName);
}

function getDeprecatedDirectiveNode(
Expand Down