Skip to content

Fix: JS grammar detects gql tags in comments #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trevor-scheer
Copy link
Contributor

@trevor-scheer trevor-scheer commented Jul 30, 2025

Just a repro for now. gql tags inside of comments are detected by the grammar and should probably be ignored. Anyone motivated to fix this: please feel free to push to this branch (if you're able) or pick my repro commit to another PR and close this one out.

Had issues running yarn vitest and yarn workspace vscode-graphql-syntax test so I added vitest as a dev dependency (and matched the version the repo uses). Perhaps I'm missing the "right" way to run these tests.

Also: not obvious to me why git is detecting the entire file changes, but hiding whitespace while reviewing reveals the actual diff in the snapshot correctly.

Copy link

changeset-bot bot commented Jul 30, 2025

⚠️ No Changeset found

Latest commit: 4501462

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

linux-foundation-easycla bot commented Jul 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: trevor-scheer / name: Trevor Scheer (4501462)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant