Refactor batching logic #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
batch-object
branch
3 times, most recently
from
5e703b2 to
5649bff
Compare
leebyron
force-pushed
the
batch-object
branch
from
5649bff to
aa52a25
Compare
leebyron
force-pushed
the
batch-object
branch
from
aa52a25 to
fe41438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking refactor of DataLoader's batching logic meant to simplify the
load()method, put a more understandable abstraction in place which can be a target for more complex behavior (such as #113)It replaces the concept of a
LoaderQueuewith aBatch. It moves all logic for creating this datastructure into a dedicated function, and moves the logic for splitting a batch (maxBatchSize) to batch creation time rather than batch dispatch time, which simplifies the dispatch logic.