Missing return in GraphQLEnumType.serialize

[congocongo]

Guess there must be a return for PyEnum type

https://github.com/graphql-python/graphql-core/blob/02605b1adce7b287fa9ee6beacd735882954159a/graphql/type/definition.py#L518-L528

[congocongo]

I meant if we initialize the enumeration by native Enum, then serializes function returns None instead members name.

for example:

import collections
from graphql.pyutils.compat import Enum as PyEnum
from graphql.type.definition import GraphQLEnumType, GraphQLEnumValue


class Color(PyEnum):
    RED = 'RED'
    GREEN = 'GREEN'
    BLUE = 'BLUE'


# init as Enum members
enum_type = GraphQLEnumType('Color', values={
                                             'RED': GraphQLEnumValue(Color.RED),
                                             'GREEN': GraphQLEnumValue(Color.GREEN),
                                             'BLUE': GraphQLEnumValue(Color.BLUE)
                                            })

print(enum_type.serialize(Color.RED))  # None
print(enum_type.serialize(Color.GREEN))  # None
print(enum_type.serialize(Color.BLUE))  # None


# correct serialize method
def serialize(self, value):
    # type: (Union[str, PyEnum]) -> Optional[str]
    if isinstance(value, (collections.Hashable, PyEnum)):
        enum_value = self._value_lookup.get(value)
        if enum_value:
            return enum_value.name

    return None

GraphQLEnumType.serialize = serialize

print(enum_type.serialize(Color.RED))  # RED
print(enum_type.serialize(Color.GREEN))  # GREEN
print(enum_type.serialize(Color.BLUE))  # BLUE

[janosroden]

This PR #198 solves this issue

[rafales]

Any news on this? It breaks using standard enum module.

[Cito]

Has been merged now, will be in next patch release.