Fragments are not properly detected for the `known-fragment-names` rule

[jgoux]

Hello all 👋,

Following the discussion here : #456 (comment)

Describe the bug

The rules known-fragment-names and no-unused-fragments are erroring even if all my fragments are loaded by graphql-eslint.

I edited the sources and logged the value of the siblings variable : https://github.com/dotansimha/graphql-eslint/blob/master/packages/plugin/src/sibling-operations.ts#L83-L88

When I run eslint CLI, here is the output : https://gist.github.com/jgoux/73b79e57b96531f89ab6c99b089c2512
You can see the errors at the end : https://gist.github.com/jgoux/73b79e57b96531f89ab6c99b089c2512#file-log-sh-L796-L818
As an example, the ProfileForm_user fragment which is in error is properly detected and loaded here : https://gist.github.com/jgoux/73b79e57b96531f89ab6c99b089c2512#file-log-sh-L98-L105

To Reproduce
Steps to reproduce the behavior:

Expected behavior

If all the fragments are detected by the plugin, I should have no errors in my case.

Environment:

• OS: MacOS Big Sur
• @graphql-eslint/...: 1.0.1
• NodeJS: v14.15.5

Additional context

[dimaMachina]

Hi @jgoux, please provide a sample repo and not output in gist.github.com

[dimaMachina]

Closing due to inactivity. Please feel free to reopen if you still need help.

[jgoux]

Sorry for taking so long! 😅

Here is the minimal repro : https://github.com/jgoux/graphql-eslint-repro

You need to run yarn & yarn lint and you will have these two errors :

It's still present on the last release 2.0.1

I don't see any option to reopen the issue.

[Urigo]

Hi @jgoux and thank you for the report

Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow.

It seems already got into stage 1 thanks to your reproduction! Thank you for that!

Now in order to advance to stage 2 we'll need a failing test, would be great if someone could help progress the issues through the stages.

Thank you and sorry that this comment is not a complete solution (yet).

[dimaMachina]

@jgoux I don’t see import comment in your file https://github.com/jgoux/graphql-eslint-repro/blob/main/src/UserProfileScreen.graphql

can you add #import './ProfileForm.graphql' at the top of UserProfileScreen.graphql file and lint it again? (I am on vacation and not able to test your reproduction on my machine)

[jgoux]

@B2o5T Indeed, it works with the #import './ProfileForm.graphql' statement, well done!

A couple of things :

• Why is this needed if we already provide the operations option as stated here : Support #import #385 (comment). I thought the operations are turned into some kind of global registry in which graphql-eslint could lookup for the fragments presence.
• It seems like the import syntax implemented for graphql-eslint has a little bug, we can't put a space character before the import keyword like # import './ProfileForm.graphql'. (which should be valid according to the doc here : https://www.graphql-tools.com/docs/schema-loading#using-import-expression)
  

[mogelbrod]

I just discovered this great project and had the same experience as @jgoux. From reading the docs I assumed the operations field removed the need to add import statements to the graphql files. Other than that everything appears to work well!

[3nvi]

I also agree with the above. Just added it to my project and it's amazing.

The only downside is that I have to disable those 2 rules around Fragments, cause I don't want to add unnecessary #import ... comments in my *.graphql operation files just to satisfy the linter