fix: always create field edges to current graphs field type #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
commented
Jun 17, 2025
| @provides(fields: "bbbbbbbbbbbbb { aaaaaaaaaaaa { someField } }") | ||
| } | ||
|
|
||
| type AAAAAAAAAAAAA @key(fields: "id") { |
There was a problem hiding this comment.
Renaming the type in all subgraphs fixes the issue... So it must be some issue with the order of things...
- AAAAAAAAAAAAA
+ AAAAAAAAAAAAThere was a problem hiding this comment.
Okay, if the field had a shorter name we attempted to create a edge from BBBBBBBBBBBBB.aaaaaaaaaaaa to SomeInterface/b instead of AAAAAAAAAAAAA/. 🤡
The changes in src/supergraph/validation/rules/satisfiablity/graph.ts should ensure we always create the field edges to the subgraph defined field type instead.
n1ru4l
changed the title
| type Post @key(fields: "id") { | ||
| id: ID! | ||
| author: User @provides(fields: "userId") | ||
| } | ||
|
|
n1ru4l
commented
Jun 17, 2025
n1ru4l
commented
Jun 17, 2025
n1ru4l
commented
Jun 17, 2025
14 tasks
jdolle
approved these changes
Jun 18, 2025
| @@ -1381,7 +1381,10 @@ export class Graph { | |||
| } | |||
| } | |||
|
|
|||
| const outputTypeName = stripTypeModifiers(field.type); | |||
| // We always want to connect it to the field type within our graph not the field type from another graph/supergraph | |||
| const fieldType = field.byGraph.get(this.id)?.type ?? field.type; | |||
kamilkisiela
approved these changes
Jun 23, 2025
n1ru4l
pushed a commit
that referenced
this pull request
Jun 23, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @theguild/[email protected] ### Patch Changes - [#151](#151) [`f9b9908`](f9b9908) Thanks [@n1ru4l](https://github.com/n1ru4l)! - Fix issue where the satisfiability check raised an exception for fields that share different object type and interface definitions across subgraphs. - [#152](#152) [`e4440a1`](e4440a1) Thanks [@n1ru4l](https://github.com/n1ru4l)! - Fix issue where scalar type marked with `@inaccessible` does not fail the composition if all usages are not marked with `@inaccessible`. Composing the following subgraphs resulted in an invalid supergraph instead of failing the composition. ```graphql # Subgraph A extend schema @link( url: "https://specs.apollo.dev/federation/v2.9" import: ["@inaccessible"] ) type Query { a: Foo } scalar Foo ``` ```graphql # Subgraph B extend schema @link( url: "https://specs.apollo.dev/federation/v2.9" import: ["@inaccessible"] ) type Query { b: String } scalar Foo @inaccessible ``` Now it correctly raises a composition error with the message `Type "Foo" is @inaccessible but is referenced by "Query.a", which is in the API schema.`. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.