Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

fix: disable recaptcha when site key is not set#5451

Merged
mderynck merged 3 commits intodevfrom
mderynck/disable-oss-recaptcha
Feb 14, 2025
Merged

fix: disable recaptcha when site key is not set#5451
mderynck merged 3 commits intodevfrom
mderynck/disable-oss-recaptcha

Conversation

@mderynck
Copy link
Copy Markdown
Contributor

@mderynck mderynck commented Feb 13, 2025

What this PR does

Although recaptcha verification is disabled by default on the backend for OSS installs, the plugin was still making use of the site key and trying to load recaptcha. As that recaptcha site was removed this no longer works. The updated plugin code will skip recaptcha verification if it does not have a site key set.

Which issue(s) this PR closes

Related to #5449

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@mderynck mderynck requested a review from a team as a code owner February 13, 2025 17:24
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mderynck
❌ actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.

@mderynck mderynck changed the title Mderynck/disable oss recaptcha Disable recaptcha when site key is not set Feb 13, 2025
@mderynck mderynck added release:patch PR will be added to "Other Changes" section of release notes pr:no public docs Added to a PR that does not require public documentation updates labels Feb 13, 2025
@mderynck mderynck changed the title Disable recaptcha when site key is not set fix: disable recaptcha when site key is not set Feb 13, 2025
@mderynck mderynck added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit cdb2946 Feb 14, 2025
25 of 28 checks passed
@mderynck mderynck deleted the mderynck/disable-oss-recaptcha branch February 14, 2025 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants