Skip to content

Update module github.com/prometheus/client_golang to v1.20.4 (main) #9307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

Update module github.com/prometheus/client_golang to v1.20.4 (main) #9307

merged 3 commits into from
Oct 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 16, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/prometheus/client_golang v1.19.1 -> v1.20.4 age adoption passing confidence
github.com/prometheus/client_golang v1.20.3 -> v1.20.4 age adoption passing confidence

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.4

Compare Source

  • [BUGFIX] histograms: Fix a possible data race when appending exemplars vs metrics gather. #​1623

v1.20.3

Compare Source

  • [BUGFIX] histograms: Fix possible data race when appending exemplars. #​1608

v1.20.2

Compare Source

  • [BUGFIX] promhttp: Unset Content-Encoding header when data is uncompressed. #​1596

v1.20.1

Compare Source

  • [BUGFIX] process-collector: Fixed unregistered descriptor error when using process collector with PedanticRegistry on Linux machines. #​1587

v1.20.0

Compare Source

Thanks everyone for contributions!

⚠️ In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #​1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #​1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #​1568 #​1578
  • [FEATURE] testutil: Add CollectAndFormat method. #​1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #​1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #​1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #​1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #​1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #​1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #​1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #​1455
  • [BUGFIX] promhttp: Make sure server
    instrumentation wrapping supports new and future extra responseWriter methods. #​1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #​1424
All commits

New Contributors

Full Changelog: prometheus/client_golang@v1.19.1...v1.20.0

Configuration

📅 Schedule: Branch creation - "before 9am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from stevesg, grafanabot and a team as code owners September 16, 2024 08:21
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch 3 times, most recently from de68535 to 7f60d32 Compare September 17, 2024 08:52
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.3 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 17, 2024
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from 7f60d32 to 0b98c4e Compare September 17, 2024 11:41
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 20, 2024
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 20, 2024
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 20, 2024
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from 0b98c4e to 3f9b711 Compare September 20, 2024 20:52
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 23, 2024
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 24, 2024
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch 2 times, most recently from 72d5777 to d40c00e Compare September 24, 2024 13:59
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 24, 2024
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 25, 2024
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from d40c00e to c34115f Compare September 25, 2024 18:27
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 25, 2024
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 25, 2024
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 27, 2024
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from c34115f to a5f0a94 Compare September 30, 2024 09:26
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 30, 2024
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Sep 30, 2024
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Oct 2, 2024
@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.4 (main) chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Oct 2, 2024
@renovate renovate bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.20.4 (main) Update module github.com/prometheus/client_golang to v1.20.4 (main) Oct 3, 2024
@renovate renovate bot force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch 2 times, most recently from 114a50c to c9d6875 Compare October 4, 2024 11:42
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 6, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@aknuds1 aknuds1 force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch 7 times, most recently from 46e6210 to 6631798 Compare October 7, 2024 09:10
@aknuds1 aknuds1 force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from 6631798 to d5837da Compare October 7, 2024 09:10
aknuds1
aknuds1 reviewed Oct 7, 2024
View reviewed changes
@aknuds1 aknuds1 requested a review from krajorama October 7, 2024 09:11
@aknuds1
Copy link
Contributor

aknuds1 commented Oct 7, 2024

Please note that I had to fix up tests due to testutil.GatherAndCompare now returning an error if some of the provided metrics are missing. See relevant change in client_golang.

@aknuds1
Fix tests
da6bba1 
Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 aknuds1 force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from d5837da to da6bba1 Compare October 7, 2024 10:01
ying-jeanne
ying-jeanne approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ying-jeanne ying-jeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from this https://cloud-native.slack.com/archives/C037NMVUAP3/p1728216119838339, nice investigation. LGTM

@aknuds1 aknuds1 marked this pull request as draft October 7, 2024 10:44
@aknuds1
Copy link
Contributor

aknuds1 commented Oct 7, 2024

Converting to draft, as @krajorama pointed out a GatherAndCompare problem I have to fix differently.

@aknuds1 aknuds1 force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch 3 times, most recently from 3a4ee86 to 192a91c Compare October 7, 2024 11:07
@aknuds1
Fix tests
348339d 
Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 aknuds1 force-pushed the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch from 192a91c to 348339d Compare October 7, 2024 12:39
@aknuds1 aknuds1 marked this pull request as ready for review October 7, 2024 12:39
krajorama
krajorama approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknuds1 aknuds1 merged commit cd1294b into main Oct 7, 2024
29 checks passed
@aknuds1 aknuds1 deleted the deps-update/main-mygithub.libinneed.workers.dev-prometheus-client_golang-1.x branch October 7, 2024 13:34
krajorama pushed a commit that referenced this pull request Oct 15, 2024
@renovate @krajorama
Revert "Update module github.com/prometheus/client_golang to v1.20.4 …
a4b9d32 
…(main) (#9307)"

This reverts commit cd1294b.

# Conflicts:
#	go.sum
#	vendor/github.com/prometheus/client_golang/prometheus/testutil/testutil.go
#	vendor/modules.txt
@krajorama krajorama mentioned this pull request Oct 15, 2024
Merged
4 tasks
krajorama added a commit that referenced this pull request Oct 16, 2024
@krajorama @renovate @aknuds1
chore(deps): vendor update mimir-prometheus at 5e9a771537ba (#9622)
c17264e 
* Test client_golang 1.20.5

Signed-off-by: György Krajcsovits <[email protected]>

* Revert "Add tests for pkg/util/test.AssertGatherAndCompare (#9543)"

This reverts commit e78254e.

* Revert "Update module github.com/prometheus/client_golang to v1.20.4 (main) (#9307)"

This reverts commit cd1294b.

# Conflicts:
#	go.sum
#	vendor/github.com/prometheus/client_golang/prometheus/testutil/testutil.go
#	vendor/modules.txt

* Clear go.mod replace

Signed-off-by: György Krajcsovits <[email protected]>

* Update mimir-prometheus at 5e9a771537ba

To get grafana/mimir-prometheus#718
client_golang update to 1.20.5 to revert breaking changes to
test utils.

Signed-off-by: György Krajcsovits <[email protected]>

* Apply suggestions from code review

Co-authored-by: Arve Knudsen <[email protected]>

* Apply suggestions

Signed-off-by: György Krajcsovits <[email protected]>

---------

Signed-off-by: György Krajcsovits <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Arve Knudsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 left review comments

@krajorama krajorama krajorama approved these changes

@stevesg stevesg Awaiting requested review from stevesg stevesg is a code owner

@grafanabot grafanabot Awaiting requested review from grafanabot

+1 more reviewer

@ying-jeanne ying-jeanne ying-jeanne approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknuds1 @krajorama @ying-jeanne