-
Notifications
You must be signed in to change notification settings - Fork 117
Add ability to authenticate to grafana using AAD auth. #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@sd2k @csmarchbanks Can you approve running the pending checks? It would be useful to know if more work is required for the PR. I do not have planned work other than responding to comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the contribution. The code mostly LGTM, I'm just a little unsure about merging this right now for a few reasons:
- Neither I nor any of the other maintainers use Azure so it's tricky for us to test this or fix any future issues
- We're hoping to (eventually) have support for OAuth inside Grafana, although we have no timelines here so it could be a while
It also seems slightly infeasible to add different auth mechanisms for every different way of running Grafana (something we're hoping to circumvent with OAuth support).
With that said, it does look like a fairly straightforward addition to the code, so we could perhaps get this in with the caveat that it's experimental.
I'll look into whether we can get some simple end to end smoke tests using an Azure Managed Grafana instance so we have a bit more confidence.
I understand about adding smoke tests. This feature currently is explicitly opt in. But I understand not breaking it. I will state that using AAD allows various auth flows that start with the logged in context of the user on the machine or service. This has been really nice when using to just have people auto logged in. |
does this PR impact the issue when trying to run the MCP server on my graffana instance which has active directory as a sign in way, as it for now returns errors from the MCP server, but when tested on local graffana instance without the active directory setup it worked properly |
Addresses #192