Skip to content

Local config implementation #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpinsonneau
Copy link

@jpinsonneau jpinsonneau commented Jun 24, 2025

This is a WIP implementing extra configs, allowing more deployments possibilities such as local or k8s.

It rely on extra environment variables to configure endpoints and TLS + forward Authorization header when provided.

  • Prometheus implementation
  • Loki implementation

Stdio run using env variables:
mcp
image

Prometheus query forwarding auth token:
image

Loki query:
image

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2025

CLA assistant check
All committers have signed the CLA.

@jpinsonneau
Copy link
Author

jpinsonneau commented Jun 24, 2025

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Getting a blank box on that 👼

Edit: here we go, it loaded after some minutes

@jpinsonneau jpinsonneau changed the title [WIP] local config implementation Local config implementation Jul 1, 2025
@jpinsonneau jpinsonneau marked this pull request as ready for review July 1, 2025 08:14
@jpinsonneau jpinsonneau requested a review from a team as a code owner July 1, 2025 08:14
@sd2k
Copy link
Collaborator

sd2k commented Jul 22, 2025

Hi @jpinsonneau, thanks for the contribution.

I'm a little confused about this PR - it seems like it results in bypassing Grafana entirely, which makes me think that it doesn't really belong in this MCP server, but instead in separate Prometheus/Loki MCP servers. I would really rather avoid adding more configuration complexity into this MCP server (which already has quite a few config options).

@jpinsonneau
Copy link
Author

Hi @jpinsonneau, thanks for the contribution.

I'm a little confused about this PR - it seems like it results in bypassing Grafana entirely, which makes me think that it doesn't really belong in this MCP server, but instead in separate Prometheus/Loki MCP servers. I would really rather avoid adding more configuration complexity into this MCP server (which already has quite a few config options).

Hi @sd2k, thanks for your feedback.

Indeed that could be in a smaller MCP server covering only Prom & Loki which could be even imported here as a dependency to avoid code duplication.
This work is part of investigations around AI connectors. Red Hat started a workgroup cross orgs about that:
https://docs.google.com/document/d/13OJvWKGKZL0V4nPpv9anitL5je92FCdQyXePcrY2N84
https://groups.google.com/g/kubernetes-sig-architecture/c/j_K2VvUhBWY/m/8KCimY5zCwAJ
cncf/tag-runtime#212

Feel free to join or ping people who could be interested 😃
Thanks

@SandersAaronD
Copy link
Contributor

MCP servers don't seem to have a set pattern now, and we're still somewhat grappling with whether the datasource should have the mcp server on it, or whether we would want to forward mcp servers from elsewhere via grafana. In this specific case it's not clear to me that this is specific to grafana, and it looks like it would make more sense to either run it side-by-side or have it forwarded to grafana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants