Skip to content

Conversation

@2Steaks
Copy link
Contributor

@2Steaks 2Steaks commented Feb 19, 2025

Prevent Github token from being exposed during build.

This PR is in response to an incident raised internally: https://raintank-corp.slack.com/archives/C08DR6C4KU5

How to test

  • run: docker build . -t har-to-k6

Prevent Github token from being exposed during build
@2Steaks 2Steaks self-assigned this Feb 19, 2025
@2Steaks 2Steaks requested a review from a team as a code owner February 19, 2025 09:43
@2Steaks 2Steaks requested review from EdvinasDaugirdas and going-confetti and removed request for a team February 19, 2025 09:43
Copy link
Contributor

@EdvinasDaugirdas EdvinasDaugirdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@2Steaks 2Steaks merged commit 8ceaa66 into master Feb 19, 2025
2 checks passed
@2Steaks 2Steaks deleted the fix/docker-leaking-token branch February 19, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants