fix(client): make WebP and VTT MIME type detection case-insensitive #12614
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_mimetype function was checking file extensions in a case-sensitive manner, causing files like "photo.WEBP" to fail validation when used with file_types=['image']. This fix makes the extension checks case-insensitive for .webp and .vtt files. Fixes gradio-app#12036 Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_mimetype()Root Cause
The
get_mimetype()function was using case-sensitive string matching (filename.endswith(".webp")), which caused files with uppercase extensions likephoto.WEBPto fall through tomimetypes.guess_type(). On some systems (especially Windows), this could returnNonefor WebP files, causing validation to fail with "Invalid file type" error.Test plan
.webpfile - should work.WEBPfile - should now work (previously failed).WebPfile - should workpytest client/python/test/test_utils.py::test_get_mimetype -vpytest client/python/test/test_utils.py::test_is_valid_file_type -vFixes #12036