feat: add ARIA landmarks for accessibility #12607
Open
+186
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add role="main" to main content container using semantic <main> element - Add role="group" with aria-label support to Block component for fieldsets - Add role="group" with aria-label to BaseForm component - Add role="dialog" and aria-modal to API docs and settings modals - Add aria-label to footer navigation Fixes gradio-app#5771 Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
role="main"to main content container using semantic<main>elementrole="group"witharia-labelsupport to Block component for fieldsetsrole="group"witharia-labelto BaseForm componentrole="dialog"andaria-modalto API docs and settings modalsaria-labelto footer navigationTest plan
Fixes #5771
Signed-off-by: majiayu000 [email protected]