-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Two bugs for gr.HTML #12599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two bugs for gr.HTML #12599
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/41222f964b2ae87b120588a2548b2f3fa23b58f0/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@41222f964b2ae87b120588a2548b2f3fa23b58f0#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/41222f964b2ae87b120588a2548b2f3fa23b58f0/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
✅ Changeset approved by @freddyaboulton
|
| >:</strong | ||
| > | ||
| <code class="error-message">{error_message}</code> | ||
| <code class="error-message">{html_error_message || css_error_message}</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo better to show both errors if there are both html and css errors, otherwise a user might think that the fix for the html error caused the css error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think displaying all the error info is useful to users/developers
|
Nice @aliabid94 changes look good but even after pulling the latest version of this PR and rebuilding the frontend, I see that the the first update doesn't work: Screen.Recording.2025-12-18.at.12.46.58.PM.mov |
freddyaboulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the correct behavior in the dev server. This LGTM @aliabid94 but would be good to check with @abidlabs !
9e27255 to
bd2066f
Compare
|
Merging for the release! Thanks @aliabid94 |

Two annoying bugs fixed for gr.HTML:
You can see the last two items in the super_html demo to demonstrate these changes,