-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Relax version of pydantic dependency in base gradio #12598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/466de51d5dc987d34aee6f8990e5e54164625725/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@466de51d5dc987d34aee6f8990e5e54164625725#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/466de51d5dc987d34aee6f8990e5e54164625725/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
|
requirements.txt
Outdated
| pandas>=1.0,<3.0 | ||
| pillow>=8.0,<13.0 | ||
| pydantic>=2.11.10,<=2.12.4 | ||
| pydantic>=2.0,<=2.12.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do >=2.0,<3.0 here and keep it narrow in mcp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how often pydantic releases breaking changes, which causes all Spaces that restart to break, imo it's better to pin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that's a good point since we install gradio[mcp] on all Spaces anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will relax more
freddyaboulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thanks @abidlabs !
In #12268, we pinned the version of
pydanticto be a very narrow range. I believe that this is leading to CI failures in https://github.com/axolotl-ai-cloud/axolotl/actions/runs/20280132253/job/58280789765?pr=3253, which is preventingaxolotlfrom upgrading to Gradio 6.0.In this PR, I relax the
pydanticdependency for basegradioand only restrict it forgradio[mcp]where it is actually needed.