-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Ensure HTML renders in gr.Chatbot #12596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/856dd886a715dd4caa378b930860afe3c7dc4fc0/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@856dd886a715dd4caa378b930860afe3c7dc4fc0#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/856dd886a715dd4caa378b930860afe3c7dc4fc0/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but can you explain why the current approach doesn't work? The chatbot (should) load BaseHTML from @gradio/html. And here we're wrapping BaseHTML. Could we instead just change how the chatbot passes props to the html component in Component.svelte?
Description
The way Chatbot passes props to gr.HTML means we need to create a wrapper around HTML to get it working. This PR adds a wrapper around gr.HTML and changes the export path to that in package.json
Closes: #12595
demo:
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh