-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Upgrade ty to 0.0.2
#12582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ty to 0.0.2
#12582
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/5602fb05e053b39bc898279486910f53a1ebc904/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@5602fb05e053b39bc898279486910f53a1ebc904#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/5602fb05e053b39bc898279486910f53a1ebc904/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
✅ Changeset approved by @abidlabs
|
freddyaboulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we disable typing on the tests? If there was a mistake, it would be caught when we run the tests.
But looks good. Not looking forward to fixing these errors later 😓
|
Hmm is it worth it to add all these type:ignore lines to our demos, which are often used in our docs? Or do we already filter out the type:ignore comments in our docs? Would be nice if we did |
The reason it's important to type the tests and demos is because they are the most representative of type errors that users are likely to use when integrating Gradio into their own code bases, so we should include them. e.g. one of our public classes might be typed as
Good idea, I'll filter them out from the demos |
|
Oh looks like we already do:
So this PR should be good for review/merge whenever |
freddyaboulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abidlabs !
|
Thanks @freddyaboulton! |
tyis now in beta, so a good time for us to upgrade from the alpha release we were using previously. Around 300 additional typing errors were caught so I've fixed some of them and asked AI to type:ignore the rest so that we can fix at our leisure.