-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix image buttons default value #12575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/5ce0c4fa925bda75eca48430dac70de5505c501a/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@5ce0c4fa925bda75eca48430dac70de5505c501a#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/5ce0c4fa925bda75eca48430dac70de5505c501a/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
✅ Changeset approved by @freddyaboulton
|
js/audio/static/StaticAudio.svelte
Outdated
| $: buttons_to_render = | ||
| buttons && buttons.length > 0 ? buttons : ["download", "share"]; | ||
| buttons && typeof buttons === "object" ? buttons : ["download", "share"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of #12539, I made it so that the "buttons" prop returned from the frontend is always a list (for the Audio component, the default returned list is ["download", "share"]). So this kind of logic should no longer be needed, you can just render the set of buttons in buttons directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix!
aliabid94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm buttons=[] works!
In the original issue, OP wanted buttons=None to hide the buttons, but that is not the current behaviour (buttons=None shows default buttons). Would be worth clarifying in the issue.
|
Thank you for the reviews @abidlabs @aliabid94 ! |
Description
Closes: #12573
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh